deprecate: host-usage, param_helpers, and prefix-1-ary #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericdeansanchez
changed the title
sherwinski
reviewed
Aug 14, 2020
sherwinski
approved these changes
Aug 15, 2020
sherwinski
approved these changes
Aug 15, 2020
ericdeansanchez
changed the title
sherwinski
approved these changes
Aug 17, 2020
ericdeansanchez
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose of this PR is to deprecate the following:
ParamHelpers#rectwithout replacement:host, replaced byoptions[:domain], @domainprefix(1), replaced byprefix(0)Host Deprecation
The change from
hosttodomainhas been made to improve consistencyon a few different levels. The technical reasons are that domain and
host refer to related, but ultimately, slightly different things.
"Host" generally refers to a particular machine that is connected to a
network whereas "domain" generally refers to some (more specific) IP
resource.
The other, equally pertinent, reasons revolve around achieving feature
parity kit-wide (e.g.
imigx-core-jsusesdomain).Imgix::Client#prefix Arity Change
At another point in time the
prefixfunction was doing more work thanit is now. The work it once did required a
pathof sorts to be passedto a
get_host(path)(2fd2387). This is no longer the case so the aritywas reduced to zero.